forked from operator-framework/operator-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ansible operator: Adding support for event filtering via predicates
Event filtering will allow Ansible operator to skip reconciles that are not required Fixes operator-framework#1968
- Loading branch information
Showing
8 changed files
with
144 additions
and
77 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| // Copyright 2019 The Operator-SDK Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package predicates | ||
|
|
||
| import ( | ||
| "reflect" | ||
|
|
||
| crtpredicate "sigs.k8s.io/controller-runtime/pkg/predicate" | ||
| "sigs.k8s.io/controller-runtime/pkg/event" | ||
| "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" | ||
| logf "sigs.k8s.io/controller-runtime/pkg/log" | ||
|
|
||
|
|
||
| ) | ||
|
|
||
| var log = logf.Log.WithName("predicates") | ||
|
|
||
| // PredicateFuncs returns functions defined for filtering events | ||
| func PredicateFuncs() crtpredicate.Funcs { | ||
|
|
||
| dependentPredicate := crtpredicate.Funcs{ | ||
| // We don't need to reconcile dependent resource creation events | ||
| // because dependent resources are only ever created during | ||
| // reconciliation. Another reconcile would be redundant. | ||
| CreateFunc: func(e event.CreateEvent) bool { | ||
| o := e.Object.(*unstructured.Unstructured) | ||
| log.V(1).Info("Skipping reconciliation for dependent resource creation", "name", o.GetName(), "namespace", o.GetNamespace(), "apiVersion", o.GroupVersionKind().GroupVersion(), "kind", o.GroupVersionKind().Kind) | ||
| return false | ||
| }, | ||
|
|
||
| // Reconcile when a dependent resource is deleted so that it can be | ||
| // recreated. | ||
| DeleteFunc: func(e event.DeleteEvent) bool { | ||
| o := e.Object.(*unstructured.Unstructured) | ||
| log.V(1).Info("Reconciling due to dependent resource deletion", "name", o.GetName(), "namespace", o.GetNamespace(), "apiVersion", o.GroupVersionKind().GroupVersion(), "kind", o.GroupVersionKind().Kind) | ||
| return true | ||
| }, | ||
|
|
||
| // Don't reconcile when a generic event is received for a dependent | ||
| GenericFunc: func(e event.GenericEvent) bool { | ||
| o := e.Object.(*unstructured.Unstructured) | ||
| log.V(1).Info("Skipping reconcile due to generic event", "name", o.GetName(), "namespace", o.GetNamespace(), "apiVersion", o.GroupVersionKind().GroupVersion(), "kind", o.GroupVersionKind().Kind) | ||
| return false | ||
| }, | ||
|
|
||
| // Reconcile when a dependent resource is updated, so that it can | ||
| // be patched back to the resource managed by the CR, if | ||
| // necessary. Ignore updates that only change the status and | ||
| // resourceVersion. | ||
| UpdateFunc: func(e event.UpdateEvent) bool { | ||
| old := e.ObjectOld.(*unstructured.Unstructured).DeepCopy() | ||
| new := e.ObjectNew.(*unstructured.Unstructured).DeepCopy() | ||
|
|
||
| delete(old.Object, "status") | ||
| delete(new.Object, "status") | ||
| old.SetResourceVersion("") | ||
| new.SetResourceVersion("") | ||
|
|
||
| if reflect.DeepEqual(old.Object, new.Object) { | ||
| return false | ||
| } | ||
| log.V(1).Info("Reconciling due to dependent resource update", "name", new.GetName(), "namespace", new.GetNamespace(), "apiVersion", new.GroupVersionKind().GroupVersion(), "kind", new.GroupVersionKind().Kind) | ||
| return true | ||
| }, | ||
| } | ||
|
|
||
| return dependentPredicate | ||
| } | ||
|
|