Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try evaling tasks with and without parentheses, closes #326 #327

Closed
wants to merge 1 commit into from
Closed

Try evaling tasks with and without parentheses, closes #326 #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion inst/www/htmlwidgets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,17 @@
theseArgs = theseArgs.concat([task.data]);
task = task.code;
}
var taskFunc = eval("(" + task + ")");
try {
var taskFunc = eval("(" + task + ")");
} catch(err) {
try {
var taskFunc = eval(task);
} catch(error) {
console.error(err);
console.error(error);
Copy link
Collaborator

@jcheng5 jcheng5 Feb 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should swallow the error here

}
}

if (typeof(taskFunc) !== "function") {
throw new Error("Task must be a function! Source:\n" + task);
}
Expand Down