Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export JSEvals #381

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Export JSEvals #381

merged 1 commit into from
Aug 25, 2020

Conversation

jcheng5
Copy link
Collaborator

@jcheng5 jcheng5 commented Aug 24, 2020

Needed for rstudio/leaflet#696

Testing notes

None, this is just exporting an existing function. It's marked "keyword internal" so it doesn't show up in the package doc index.

@jcheng5 jcheng5 requested a review from cpsievert August 24, 2020 19:09
@jcheng5 jcheng5 merged commit 52bf875 into master Aug 25, 2020
@jcheng5 jcheng5 deleted the joe/feature/export-jsevals branch August 25, 2020 21:08
schloerke added a commit to schloerke/htmlwidgets that referenced this pull request Sep 30, 2020
* upstream/master:
  Bump dev version
  Export JSEvals (ramnathv#381)
  Add missing roxygenize step (ramnathv#370)
  Add reportTheme arg to shinyWidgetOutput() (ramnathv#361)
  Try evaluating code with parentheses before without parentheses, closes ramnathv#356. (ramnathv#357)
  Bump version for development
  v1.5.1 release candidate (ramnathv#353)
  Add a comment; abstract out duplication in logic (ramnathv#354)
  Prevent staticRender from being called unconditionally when htmlwidgets.js is loaded after page load
  Bump version; update NEWS
  Use  to schedule staticRender() iff jQuery 3 or higher is present in shinyMode
  Bump version
  Bump version for release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants