Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement is_full_page_or_database #198

Merged
merged 2 commits into from Aug 17, 2023
Merged

Implement is_full_page_or_database #198

merged 2 commits into from Aug 17, 2023

Conversation

ramnes
Copy link
Owner

@ramnes ramnes commented Jun 29, 2023

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1691d36) 100.00% compared to head (ac786ee) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #198   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          290       294    +4     
=========================================
+ Hits           290       294    +4     
Impacted Files Coverage Δ
notion_client/helpers.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ramnes
Copy link
Owner Author

ramnes commented Jun 29, 2023

@mutt0-ds I don't really like that I have to rebuild all cassettes since I don't have the same API key and parent page id as yours. Do you have any idea on how we could avoid this?

@mutt0-ds
Copy link
Contributor

mutt0-ds commented Jul 2, 2023

@ramnes my suggestion is that you regenerate them with a key and parent page id on your own and eventually handle the official credentials to contributors (myself included), like you have done in the PR. My test was made with a disposable account because I wanted to use cassettes locally, independently from who was running the tests.

Sure, committing all of them each time is annoying but I don't see how to bypass the issue, maybe by masking the data that changes in the yaml such as ID and time, but it will require more time and complexity than the benefit.

@ramnes ramnes merged commit 1a8bdd4 into main Aug 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants