Fixed auto_follow_distance #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramokz
requested changes
Apr 30, 2024
It does! I'll add that in there :) |
|
@ramokz Fixed :) |
ramokz
approved these changes
Apr 30, 2024
Absolutely! Glad to help! :) ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was following the v7.0 branch. I saw it got merged into master so I synced my fork with master. I noticed there was a large refactor before merging in and it appears the correct assignment of "distance" was replaced with an incorrect assignment of "follow_distance". Fortunately I have the old v7.0 branch cached on my fork. You can see it here: https://github.com/Lange-Studios/phantom-camera/blob/dc3961faab3bdbd3d04790db49091d7601c93dfc/addons/phantom_camera/scripts/phantom_camera/phantom_camera_3D.gd#L580
Also, you can test the example follow group and see that auto follow distance is broken.
Thanks for the awesome asset btw! This was a simple fix :)