New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#160 list deserializer propagates fork_inst #161
#160 list deserializer propagates fork_inst #161
Conversation
01f6333
to
daf5fe9
Compare
daf5fe9
to
b4966fd
Compare
Seems that Python3.5 is no longer available on Actions. Can you turn it off so the checks can run on the other versions?
Those failed checks don't seem to be my fault, are they? |
No, it seems that Python3.5 can no longer be installed with Actions on an x64 architecture... Can you maybe turn off the checks for 3.5 to see if the checks at least succeed for recent Python versions? |
b4966fd
to
bb21dff
Compare
It says, "1 workflow awaiting approval". Apparently, you have to sign off on workflow executions, for PRs from first time contributors. |
Upgraded `setup-python` to `setup-pythonv3` to resolve the issues with python versions.
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 60 60
Lines 1488 1488
=========================================
Hits 1488 1488
Continue to review full report at Codecov.
|
All is green now. I had to upgrade Thank you @patrickguenther , I will gladly merge and release this! |
resolves #160
Other container serializers/deserializers don't seem to be affected by this bug, since they seem to already handle fork_inst correctly, though I haven't tested this.