Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImageColumn.php #33

Closed
wants to merge 1 commit into from
Closed

Conversation

KenKodz
Copy link
Contributor

@KenKodz KenKodz commented Oct 12, 2023

Remove the default of protected bool $header = false; in ImageColumn.php to reflect the default state as documented at https://ramonrietdijk.github.io/livewire-tables/usage/columns.html#header

Remove the default of `protected bool $header = false;`  in `ImageColumn.php` to reflect the default state as documented at https://ramonrietdijk.github.io/livewire-tables/usage/columns.html#header
@ramonrietdijk
Copy link
Owner

Hi @KenKodz,

Thank you for your contribution!

The documentation states that a header can be disabled. However, the documentation also states that image columns have their header disabled by default.

This change would also mean that projects that are currently using image columns would now need to add extra code which I don't really like.

That's why I'm unfortunately going to close this pull request.

@KenKodz
Copy link
Contributor Author

KenKodz commented Oct 12, 2023

Fair enough. I didn't see it in the image column docs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants