Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Sync with PUBG API known issues #85

Merged
merged 3 commits into from
Sep 16, 2019
Merged

✏️ Sync with PUBG API known issues #85

merged 3 commits into from
Sep 16, 2019

Conversation

glmn
Copy link
Collaborator

@glmn glmn commented Sep 16, 2019

Set to FeulPercent instead of FuelPercent
PUBG Known-issues

@codecov-io
Copy link

codecov-io commented Sep 16, 2019

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files          11       11           
  Lines         750      750           
  Branches       33       33           
=======================================
  Hits          700      700           
  Misses         46       46           
  Partials        4        4
Impacted Files Coverage Δ
pubg_python/domain/telemetry/objects.py 99.15% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec34886...9f738dd. Read the comment docs.

@glmn glmn changed the title ✏️ Set Vehicle.FeulPercent ✏️ Sync with PUBG API known issues Sep 16, 2019
Copy link
Owner

@ramonsaraiva ramonsaraiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now - let me know if you're adding more commits to this.

@glmn
Copy link
Collaborator Author

glmn commented Sep 16, 2019

@ramonsaraiva
Ready to merge.

@ramonsaraiva ramonsaraiva merged commit 67ad249 into master Sep 16, 2019
@glmn glmn self-assigned this Sep 25, 2019
@glmn glmn deleted the known-issues branch September 30, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants