New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring part 2 #13

Merged

lipanski merged 1 commit into master from refactor_errors

Jul 16, 2017

Contributor

lipanski commented Jul 16, 2017 •

edited

when an error occured, return TokenError instead of String
create the ErrorType enum because the error types are limited according to the RFC
add state to TokenError (part of the RFC)
turn the optional TokenError fields into Option
write tests for error cases
move code around to have struct definitions next to their implementations


          Return TokenError instead of String. Write tests for error cases. Add…

4e59c06

… state to TokenError.

lipanski changed the title ~~Refactoring part II~~ Refactoring part 2

lipanski mentioned this pull request

a few things I'd like to improve #8

Closed

7 tasks

lipanski merged commit 9b309b3 into master

lipanski deleted the refactor_errors branch

July 16, 2017 17:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment