breaking change: use a helper type to accept static str
s as well as heap-allocated String
s in builders and API
#171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored parts of the API to accept
str
as well asString
to reduce unnecessary allocations.I decided to not use
Cow<'static, str>
and instead made theAsStr
type in order to implement theas_str
function for backwards compatibility. Despite backwards-compatibility-aware changes, this may introduce breaking changes for some users, so a major version change would be required for this PR.