Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated "failure" with "thiserror" and "anyhow" #90

Closed
wants to merge 1 commit into from

Conversation

s-panferov
Copy link
Contributor

The failure crate was deprecated recently, so this PR removes it
in favor of thiserror.

@s-panferov s-panferov force-pushed the master branch 2 times, most recently from a4bb947 to 71fccf2 Compare May 6, 2020 04:56
@ramosbugs
Copy link
Owner

thanks for the PR, and apologies for the slow response. I do plan to merge this in, but I need to coordinate it with migrating the error handling in my employer's codebase, since this affects the cause chaining that differs between failure and the other error handling crates

@ramosbugs ramosbugs closed this Jun 14, 2020
@ramosbugs ramosbugs reopened this Jun 14, 2020
@ramosbugs ramosbugs changed the base branch from master to main June 14, 2020 17:11
@mettke mettke mentioned this pull request Jun 15, 2020
8 tasks
@ramosbugs
Copy link
Owner

Merged this in 09529db

@ramosbugs ramosbugs closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants