Skip to content

Commit

Permalink
rust: remove Default implementation for enums
Browse files Browse the repository at this point in the history
PR OpenAPITools#15856 removed the derived Default implementations for structs, but left
those for enums. Since enums do not have a sensible default (see OpenAPITools#10845),
these should not be derived either. This is technically a breaking change,
but it's also a bug fix since Default was intended to be removed in 7.0.0.
  • Loading branch information
ramosbugs committed Dec 3, 2023
1 parent 62faa53 commit eb13dd6
Show file tree
Hide file tree
Showing 26 changed files with 0 additions and 166 deletions.
16 changes: 0 additions & 16 deletions modules/openapi-generator/src/main/resources/rust/model.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,6 @@ impl ToString for {{{classname}}} {
}
}
}

impl Default for {{{classname}}} {
fn default() -> {{{classname}}} {
{{#allowableValues}}
Self::{{ enumVars.0.name }}
{{/allowableValues}}
}
}
{{/isEnum}}

{{!-- for schemas that have a discriminator --}}
Expand Down Expand Up @@ -103,14 +95,6 @@ pub enum {{{enumName}}} {
{{/enumVars}}
{{/allowableValues}}
}

impl Default for {{{enumName}}} {
fn default() -> {{{enumName}}} {
{{#allowableValues}}
Self::{{ enumVars.0.name }}
{{/allowableValues}}
}
}
{{/isEnum}}
{{/vars}}

Expand Down
6 changes: 0 additions & 6 deletions samples/client/petstore/rust/hyper/petstore/src/models/baz.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,6 @@ impl ToString for Baz {
}
}

impl Default for Baz {
fn default() -> Baz {
Self::A
}
}




Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,3 @@ pub enum RequiredEnums {
C,
}

impl Default for RequiredEnums {
fn default() -> RequiredEnums {
Self::A
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,3 @@ pub enum Status {
Delivered,
}

impl Default for Status {
fn default() -> Status {
Self::Placed
}
}

6 changes: 0 additions & 6 deletions samples/client/petstore/rust/hyper/petstore/src/models/pet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,3 @@ pub enum Status {
Sold,
}

impl Default for Status {
fn default() -> Status {
Self::Available
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,3 @@ pub enum UniqueItemArray {
Variant3,
}

impl Default for UniqueItemArray {
fn default() -> UniqueItemArray {
Self::Variant1
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,6 @@ impl ToString for Baz {
}
}

impl Default for Baz {
fn default() -> Baz {
Self::A
}
}




Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,3 @@ pub enum RequiredEnums {
C,
}

impl Default for RequiredEnums {
fn default() -> RequiredEnums {
Self::A
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,3 @@ pub enum Status {
Delivered,
}

impl Default for Status {
fn default() -> Status {
Self::Placed
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,3 @@ pub enum Status {
Sold,
}

impl Default for Status {
fn default() -> Status {
Self::Available
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,3 @@ pub enum UniqueItemArray {
Variant3,
}

impl Default for UniqueItemArray {
fn default() -> UniqueItemArray {
Self::Variant1
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,6 @@ impl ToString for Baz {
}
}

impl Default for Baz {
fn default() -> Baz {
Self::A
}
}




Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,3 @@ pub enum RequiredEnums {
C,
}

impl Default for RequiredEnums {
fn default() -> RequiredEnums {
Self::A
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,3 @@ pub enum Status {
Delivered,
}

impl Default for Status {
fn default() -> Status {
Self::Placed
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,3 @@ pub enum Status {
Sold,
}

impl Default for Status {
fn default() -> Status {
Self::Available
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,3 @@ pub enum UniqueItemArray {
Variant3,
}

impl Default for UniqueItemArray {
fn default() -> UniqueItemArray {
Self::Variant1
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,6 @@ impl ToString for Baz {
}
}

impl Default for Baz {
fn default() -> Baz {
Self::A
}
}




Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,3 @@ pub enum RequiredEnums {
C,
}

impl Default for RequiredEnums {
fn default() -> RequiredEnums {
Self::A
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,3 @@ pub enum Status {
Delivered,
}

impl Default for Status {
fn default() -> Status {
Self::Placed
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,3 @@ pub enum Status {
Sold,
}

impl Default for Status {
fn default() -> Status {
Self::Available
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,3 @@ pub enum UniqueItemArray {
Variant3,
}

impl Default for UniqueItemArray {
fn default() -> UniqueItemArray {
Self::Variant1
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,6 @@ impl ToString for Baz {
}
}

impl Default for Baz {
fn default() -> Baz {
Self::A
}
}




Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,3 @@ pub enum RequiredEnums {
C,
}

impl Default for RequiredEnums {
fn default() -> RequiredEnums {
Self::A
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,3 @@ pub enum Status {
Delivered,
}

impl Default for Status {
fn default() -> Status {
Self::Placed
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,3 @@ pub enum Status {
Sold,
}

impl Default for Status {
fn default() -> Status {
Self::Available
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,3 @@ pub enum UniqueItemArray {
Variant3,
}

impl Default for UniqueItemArray {
fn default() -> UniqueItemArray {
Self::Variant1
}
}

0 comments on commit eb13dd6

Please sign in to comment.