Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect paginator to new slides/panels layout #53

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

yileifeng
Copy link
Member

@yileifeng yileifeng commented Nov 17, 2021

Closes #47

Reorganizes some Vue component files and connect paginator to using the new slides/panels. Adds a title property to slides in the config/schema that was discussed. The old story map has also been removed with this PR but the files remain (unused).


This change is Reviewable

Copy link
Member

@JahidAhmed JahidAhmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

@JahidAhmed JahidAhmed merged commit 0e110f8 into ramp4-pcar4:master Nov 17, 2021
@yileifeng yileifeng deleted the 47-story-paginator branch April 21, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect panels to paginator
3 participants