Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated client and server code for internal deployment #290

Merged
merged 1 commit into from
May 9, 2024

Conversation

szczz
Copy link
Member

@szczz szczz commented Apr 30, 2024

Changes

  • This PR includes the changes needed for the intranet deployment. This build is currently deployed on Dev, UAT, and QA
  • Once merged, the build pipelines will need to be updated to point to the main branch.

Notes

We will need to remove the R4MP build files once this issue is complete.

Testing

Steps:

  1. These changes should work locally and when deployed. Please checkout the DevDeployment branch and attempt to use the editor locally.
  2. Test editor features on dev or uat.

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/DevDeployment/#/en/editor

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 18 of 23 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @szczz)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Features worked well when testing on dev and locally 🏆

Some UI issues with slide ToC but can just throw it into the pile in #294

image.png

Reviewed 18 of 23 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @szczz)

@yileifeng yileifeng merged commit 7f5b3d0 into ramp4-pcar4:main May 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants