Restart required when chatting to new users

[sunayansaikia]

Hi,
I have encountered a big issue. Say you entered a slack domain and it has several users. When a new user that haven't yet talked to the JBot, the JBot fails to take inputs. But when a restart of the spring-boot service is done, those users who tried interacting with the bots and failed are now are able to interact.
Can you please, tell me where can the problem be as soon as possible. :)

[rampatra]

Hmm, it never happened to me. Let others comment on it too. Will keep this issue open.

[sunayansaikia]

Found the root cause. Inside the following method,
public final void handleTextMessage(WebSocketSession session, TextMessage textMessage)()

Root cause - Slack's im_created event gets triggered while talking to a newly added user.
As mentioned in this im_created event guide, this event should usually be followed by a im_open event which your code is looking for. But, that's not the case. I think, that's what they meant by 'usually'? Whatever be the case, I have added the check for the im_created in the code.

[Note]: Check this bug I raised in slack issues.

[rampatra]

Glad your issue is resolved.

[lurraca]

@sunayansaikia I am facing the same issue. What do you mean by

added the check for the im_created in the code.

?

[lurraca]

Ok, I think I got it.

I made the change on the Jbot source code to check for im_created and add the channel to DmChannels list, so when that new user sends a direct message to the bot, jbot is able to determine that is a DIRECT_MESSAGE. @ramswaroop is this something that you would like me to send a PR to fix it?

[rampatra]

Hi @lurraca, looks like jbot should check for both the events. Yes, definitely you can send a PR for the fix. Thanks a mil for contributing. 👍

[mndominguez]

I'm having this same issue. @ramswaroop do you think you can merge the PR? If the issue is that @lurraca did not change the code to check both event types, I can go ahead and do it. Thanks, great project BTW!

[rampatra]

@mndominguez okay I will do that today 👍

[rampatra]

@mndominguez I just merged @lurraca PR #57.

[mndominguez]

@ramswaroop fantastic, thank you! Is the fix going to be on a new build on Maven Central?

[rampatra]

@mndominguez no it's not gone to maven yet. I will release it after some tests which may take some days as I am working on other new features as well.