Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environmental variables should have the prefix SPOTIFY_ #118

Closed
marioortizmanero opened this issue Aug 17, 2020 · 2 comments · Fixed by #119
Closed

Environmental variables should have the prefix SPOTIFY_ #118

marioortizmanero opened this issue Aug 17, 2020 · 2 comments · Fixed by #119

Comments

@marioortizmanero
Copy link
Collaborator

marioortizmanero commented Aug 17, 2020

The environmental variable names currently are CLIENT_ID, CLIENT_SECRET and REFRESH_TOKEN. I think it would be a better idea to use these same names with the prefix SPOTIFY_ to avoid name collisions with other programs/libraries that use OAuth2, like SPOTIFY_CLIENT_ID.

By the way, I'll leave for 3-4 days so I won't be able to respond to issues/PRs.

@ramsayleung
Copy link
Owner

I think it would be a better idea to use these same names with the prefix SPOTIFY_ to avoid name collisions with other programs/libraries that use OAuth2, like SPOTIFY_CLIENT_ID.

I think it will be better to have the prefix RSPOTIFY_ just avoid name collisions with other Spotify libraries.

@marioortizmanero
Copy link
Collaborator Author

That's not a bad idea either. I think collisions with other Spotify libraries aren't that bad because you can share the credentials, but I'd rather keep it trouble-free with RSPOTIFY-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants