Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using proxy #59

Closed
conilas opened this issue Oct 16, 2019 · 2 comments
Closed

Using proxy #59

conilas opened this issue Oct 16, 2019 · 2 comments

Comments

@conilas
Copy link

conilas commented Oct 16, 2019

Hey there!

I tried to use spotify-tui (which apparently uses this library) inside my company, where everything runs behind a proxy. After a little digging, I noticed they were trying to get the json token for oauth (https://github.com/ramsayleung/rspotify/blob/master/src/spotify/oauth2.rs), but the client from reqwest is being built without the proxy.

They have a good doc on it (https://docs.rs/reqwest/0.7.0/reqwest/struct.Proxy.html), so I was able to change the Client building line the proxy.

Question is: do you guys plan to have any take on that? I might be able to make a PR if that is not/not supposed to be in the roadmap or anything.

Thanks!

@ramsayleung
Copy link
Owner

PR is certainly welcome, It frustrated that I don't have time to add proxy feature to rspotify now, hence it's great if you could contribute to it.

@ramsayleung
Copy link
Owner

ramsayleung commented Jan 20, 2020

I have updated reqwest to the latest version, now rspotify supports system proxy by default(Notes that reqwest system proxy doesn't support socks proxy for now, check this issue for more details). For more details, please check this PR #70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants