Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded dependencies #105

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Upgraded dependencies #105

merged 1 commit into from
Aug 14, 2020

Conversation

marioortizmanero
Copy link
Collaborator

@marioortizmanero marioortizmanero commented Aug 12, 2020

I ran a cargo upgrade from cargo-edit to update the dependencies used in this module. I strongly suggest integrating Dependabot here so that this is taken care of automatically. It's really easy to use and avoids having to update all dependencies at once.

The only change I had to make so that the examples compiled was upgrading percent_encoding to v2.X. I simply followed the instructions indicated on their repo for the encoding set this module used.

On a side note: I think the base64 dependency may be unnecessary. I don't see where it's exactly being used, and the examples still compile after removing it from Cargo.toml and the extern crate from lib.rs.

Edit: please merge #106 first so that I can update this afterwards.

@marioortizmanero
Copy link
Collaborator Author

I've updated this PR after #106 has been merged, @ramsayleung. You can now review this when you have time.

@ramsayleung
Copy link
Owner

ramsayleung commented Aug 14, 2020

I strongly suggest integrating Dependabot here so that this is taken care of automatically.

Yeah, I would like to take time to figure out how it works, and integrate it later. I just integrate Dependabot with this PR #111 everything is well set.

@ramsayleung ramsayleung merged commit af19456 into ramsayleung:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants