Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings #484

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

thirteenowls
Copy link
Contributor

Description

Fixed clippy warnings.

Motivation and Context

#483 (comment)

Dependencies

None.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

By running clippy and observing no warnings.

Is this change properly documented?

N/A

@thirteenowls
Copy link
Contributor Author

Missed a couple, sorry. I'd only tested using the feature combinations I saw fail in CI.
clippy::assigning_clones will be moved to pedantic in the next release, and its current recommendation to use ToOwned::clone_into is incompatible with rspotify's MSRV, so I thought it'd be best to simply allow it for the time being.

@ramsayleung ramsayleung merged commit 4a4f704 into ramsayleung:master May 23, 2024
7 checks passed
@ramsayleung
Copy link
Owner

No worries, thanks for your contribution.

@thirteenowls thirteenowls deleted the fix-clippy branch May 23, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants