Skip to content

Commit

Permalink
ci: use container for both benchmarks for parity
Browse files Browse the repository at this point in the history
  • Loading branch information
ramsey committed Sep 28, 2022
1 parent d779c3e commit ade58e2
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions .github/workflows/continuous-integration.yml
Expand Up @@ -129,19 +129,15 @@ jobs:
uses: "codecov/codecov-action@v3.1.1"

benchmark:
name: "Benchmark (${{ matrix.artifact-name }})"
name: "Benchmark"
needs: ["code-coverage"]
runs-on: "ubuntu-latest"
container: "${{ matrix.container }}"
container: "setupphp/node:latest-${{ matrix.arch }}"

strategy:
matrix:
include:
- php: "8.1"
artifact-name: "8.1, amd64"
- php: "8.1"
container: "setupphp/node:latest-i386"
artifact-name: "8.1, i386"
php: ["8.1"]
arch: ["amd64", "i386"]

steps:
- name: "Configure Git"
Expand All @@ -168,7 +164,7 @@ jobs:
- name: "Upload benchmark artifacts"
uses: "actions/upload-artifact@v3.1.0"
with:
name: "Benchmark (PHP ${{ matrix.artifact-name }})"
name: "Benchmark (PHP ${{ matrix.php }}, ${{ matrix.arch }})"
path: "build/bench/"

unit-tests:
Expand Down

0 comments on commit ade58e2

Please sign in to comment.