Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for symfony/console v4 #3

Merged
merged 3 commits into from
Nov 6, 2017
Merged

Add support for symfony/console v4 #3

merged 3 commits into from
Nov 6, 2017

Conversation

sstok
Copy link
Contributor

@sstok sstok commented Nov 3, 2017

Symfony 4 is still in beta at the moment, which requires the need for the minimum stability (for testing only).

@ramsey
Copy link
Owner

ramsey commented Nov 3, 2017

If you take a look at the build, none of the jobs chose to use Symfony 4. Can you update the Travis matrix to provide new jobs that force Composer to use the Symfony 4 components?

https://travis-ci.org/ramsey/uuid-console/builds/296798124

Thanks!

@sstok
Copy link
Contributor Author

sstok commented Nov 5, 2017

Done 👍 I used a little if-statement to detect if a latest unstable needs to be installed.
Once Symfony 4 is released this will also ensure any new dev version is working properly.

@ramsey
Copy link
Owner

ramsey commented Nov 6, 2017

I made a few changes to the Travis script. I'll see how this runs and then merge it in. Thanks!

@ramsey
Copy link
Owner

ramsey commented Nov 6, 2017

All passes. Thanks for the contribution!

@ramsey ramsey merged commit a1d9a9c into ramsey:master Nov 6, 2017
@sstok sstok deleted the symfony4-compat branch November 16, 2017 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants