UuidOrderedTimeGenerator: reuse global UuidFactory instead of new'ing it #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(allows UuidFactory to be user-configured)
sserbin
force-pushed
the
uuidOrdered-reuse-global-factory
branch
from
bb630c8
to
65317fd
Compare
ramsey
approved these changes
Jul 18, 2017
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows UuidFactory to be user-configured
See #36
Edit: cloning the global factory to avoid unintended side-effects (i.e. modifying its codec - which would prevent from generating both orderedTime and regular uuids)