Make serialize(UuidInterface) more compact

Resolves #318
ramsey · Jul 8, 2020 · 22ee596 · 22ee596
1 parent a741fc6
commit 22ee596
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 6 deletions.
diff --git a/src/Fields/SerializableFieldsTrait.php b/src/Fields/SerializableFieldsTrait.php
@@ -15,7 +15,7 @@
 namespace Ramsey\Uuid\Fields;
 
 use function base64_decode;
-use function base64_encode;
+use function strlen;
 
 /**
  * Provides common serialization functionality to fields
@@ -39,7 +39,7 @@ abstract public function getBytes(): string;
      */
     public function serialize(): string
     {
-        return base64_encode($this->getBytes());
+        return $this->getBytes();
     }
 
     /**
@@ -51,6 +51,10 @@ public function serialize(): string
      */
     public function unserialize($serialized): void
     {
-        $this->__construct(base64_decode($serialized));
+        if (strlen($serialized) === 16) {
+            $this->__construct($serialized);
+        } else {
+            $this->__construct(base64_decode($serialized));
+        }
     }
 }
diff --git a/src/Uuid.php b/src/Uuid.php
@@ -273,7 +273,7 @@ public function jsonSerialize(): string
      */
     public function serialize(): string
     {
-        return $this->toString();
+        return $this->getBytes();
     }
 
     /**
@@ -286,8 +286,14 @@ public function serialize(): string
      */
     public function unserialize($serialized): void
     {
-        /** @var \Ramsey\Uuid\Uuid $uuid */
-        $uuid = self::fromString($serialized);
+        if (strlen($serialized) === 16) {
+            /** @var Uuid $uuid */
+            $uuid = self::fromBytes($serialized);
+        } else {
+            /** @var Uuid $uuid */
+            $uuid = self::fromString($serialized);
+        }
+
         $this->codec = $uuid->codec;
         $this->numberConverter = $uuid->numberConverter;
         $this->fields = $uuid->fields;

diff --git a/tests/Rfc4122/FieldsTest.php b/tests/Rfc4122/FieldsTest.php
@@ -212,4 +212,14 @@ public function testSerializingFields(): void
 
         $this->assertEquals($fields, $unserializedFields);
     }
+
+    public function testSerializingFieldsWithOldFormat(): void
+    {
+        $fields = new Fields("\xb3\xcd\x58\x6a\xe3\xca\x44\xf3\x98\x8c\xf4\xd6\x66\xc1\xbf\x4d");
+
+        $serializedFields = 'C:26:"Ramsey\Uuid\Rfc4122\Fields":24:{s81YauPKRPOYjPTWZsG/TQ==}';
+        $unserializedFields = unserialize($serializedFields);
+
+        $this->assertEquals($fields, $unserializedFields);
+    }
 }
diff --git a/tests/UuidTest.php b/tests/UuidTest.php
@@ -1538,6 +1538,16 @@ public function testSerialize(): void
         $this->assertTrue($uuid->equals($unserializedUuid));
     }
 
+    public function testSerializeWithOldStringFormat(): void
+    {
+        $serialized = 'C:26:"Ramsey\Uuid\Rfc4122\UuidV4":36:{b3cd586a-e3ca-44f3-988c-f4d666c1bf4d}';
+
+        /** @var UuidInterface $unserializedUuid */
+        $unserializedUuid = unserialize($serialized);
+
+        $this->assertSame('b3cd586a-e3ca-44f3-988c-f4d666c1bf4d', $unserializedUuid->toString());
+    }
+
     public function testUuid3WithEmptyNamespace(): void
     {
         $this->expectException(InvalidArgumentException::class);