Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a different PRNG #1

Closed
marijn opened this issue Aug 2, 2012 · 8 comments
Closed

Allow for a different PRNG #1

marijn opened this issue Aug 2, 2012 · 8 comments

Comments

@marijn
Copy link
Contributor

marijn commented Aug 2, 2012

First of, great job! This seems to be one of the most solid UUID implementations for PHP.

I was wondering if you would mind having a dedicated UuidGenerator class which would house all the factories for generating the different Uuid implementations. In particular, this would allow us to inject a different PRNG.

Are you open to such a change?

@ramsey
Copy link
Owner

ramsey commented Aug 2, 2012

That sounds good to me. Are you thinking of moving the static methods in Uuid out to a UuidGenerator class and allowing for a new PRNG to be statically set on the UuidGenerator (or something like that)?

@marijn
Copy link
Contributor Author

marijn commented Aug 3, 2012

Not statically. It would just be an instance property. I'll post some pseudo code later today.

@ramsey
Copy link
Owner

ramsey commented Jul 29, 2013

@marijn, I'm just curious where this stands and whether you're still thinking of implementing this.

@marijn
Copy link
Contributor Author

marijn commented Jul 29, 2013

I'm definitely still thinking of implementing this. However, I do have a lot on my plate at the moment so it's definitely not going to be anytime soon.

@RSully
Copy link

RSully commented Aug 14, 2014

Any more thought put into this?

@marijn
Copy link
Contributor Author

marijn commented Aug 14, 2014

I wish I had more 🕐

@ramsey ramsey added this to the Version 3.0.0 milestone Oct 30, 2014
@ramsey
Copy link
Owner

ramsey commented Oct 30, 2014

I'm wondering if this could be related to some of the discussion on #34 and as a better implementation to support GUIDs and other UUIDs.

@marijn, if you could sketch out some of your ideas for the interface for the UuidGenerator, I could help get started on the internals for this. I'm targeting the 3.0 branch for this.

ramsey pushed a commit that referenced this issue Nov 9, 2014
Refactoring the refactoring 😏 ~~ refactorin'ception :evil:
@ramsey
Copy link
Owner

ramsey commented Dec 17, 2014

This work has been merged into the 3.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants