-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for a different PRNG #1
Comments
That sounds good to me. Are you thinking of moving the static methods in Uuid out to a UuidGenerator class and allowing for a new PRNG to be statically set on the UuidGenerator (or something like that)? |
Not statically. It would just be an instance property. I'll post some pseudo code later today. |
@marijn, I'm just curious where this stands and whether you're still thinking of implementing this. |
I'm definitely still thinking of implementing this. However, I do have a lot on my plate at the moment so it's definitely not going to be anytime soon. |
Any more thought put into this? |
I wish I had more 🕐 |
I'm wondering if this could be related to some of the discussion on #34 and as a better implementation to support GUIDs and other UUIDs. @marijn, if you could sketch out some of your ideas for the interface for the |
Refactoring the refactoring 😏 ~~ refactorin'ception :evil:
This work has been merged into the 3.0 branch. |
First of, great job! This seems to be one of the most solid UUID implementations for PHP.
I was wondering if you would mind having a dedicated
UuidGenerator
class which would house all the factories for generating the differentUuid
implementations. In particular, this would allow us to inject a different PRNG.Are you open to such a change?
The text was updated successfully, but these errors were encountered: