Confusing phpstan errors

[ramsey]

In the 4.x branch, phpstan is emitting the following errors:

14.08s$ composer run phpstan
> phpstan analyse -c phpstan.neon src --level 2 --no-progress
 [OK] No errors                                                                 
> phpstan analyse -c phpstan-tests.neon tests --level 2 --no-progress
 ------ ------------------------------------------------------------------------- 
  Line   tests/src/Converter/Time/DegradedTimeConverterTest.php                   
 ------ ------------------------------------------------------------------------- 
         Class Ramsey\Uuid\Test\Converter\Time\DegradedTimeConverterTest was not  
         found while trying to analyse it - autoloading is probably not           
         configured properly.                                                     
 ------ ------------------------------------------------------------------------- 
 ------ ------------------------------------------------------------------------- 
  Line   tests/src/Validator/ValidatorTest.php                                    
 ------ ------------------------------------------------------------------------- 
         Class Ramsey\Uuid\Test\Validator\ValidatorTest was not found while       
         trying to analyse it - autoloading is probably not configured properly.  
 ------ ------------------------------------------------------------------------- 
 [ERROR] Found 2 errors                                                         
Script phpstan analyse -c phpstan-tests.neon tests --level 2 --no-progress handling the phpstan event returned with error code 1

See here: https://travis-ci.org/ramsey/uuid/builds/331056453

I don't know enough about phpstan to understand what is going on or why these errors are occurring. These test files are no longer at these locations. I moved them a while back, so I'm not sure why it's trying to do anything with them.

[ramsey]

@mhujer, since you contributed the phpstan PR, can you take a look at this and see what's going on? Thanks!

[mhujer]

@ramsey I'm afraid that something went wrong during the rebase, the files are actually there (as PHPStan says):

[mhujer]

I think that something else also went wrong during the rebase. I've pushed to original 4.x branch to my fork https://github.com/mhujer/uuid/commits/4.x-before-rebase-2018-01-19 You can fetch it and compare it with the current 4.x.

I've created #208 which fixes some parts of the diff between old and new 4.x.

[ramsey]

Thanks. I’ll take a look at your PR. I also did a diff on the old 4.x and the new, and I didn’t see anything missing, but those files could have sneaked by.

That’s what I get for trying to clean things up. 😁