Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issues with docs #297

Merged
merged 2 commits into from
Mar 15, 2020
Merged

Fix small issues with docs #297

merged 2 commits into from
Mar 15, 2020

Conversation

jpjoao
Copy link
Contributor

@jpjoao jpjoao commented Mar 15, 2020

Description

Quick proofread of the documentation

Motivation and context

Request on twitter =)

How has this been tested?

Reading 🤷‍♂️

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have run composer run-script test locally, and there were no failures or errors.

Copy link
Owner

@ramsey ramsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in here looks great. Thanks so much!

I have one small question about one of the changes, which looks like it could have been committed accidentally. Let me know what you think?

Thanks again!

docs/database.rst Outdated Show resolved Hide resolved
Co-Authored-By: Ben Ramsey <ben@benramsey.com>
@ramsey ramsey merged commit ebce23f into ramsey:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants