Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved performance of Uuid::fromString(), Uuid::fromBytes(), UuidInterface#toString(), UuidInterface#getBytes() #324

Merged
merged 13 commits into from
Jul 10, 2020
Merged

Improved performance of Uuid::fromString(), Uuid::fromBytes(), UuidInterface#toString(), UuidInterface#getBytes() #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8d42044
Minimal benchmarks around `Uuid::fromString()`, `Uuid::fromBytes()`, …
Ocramius Jun 30, 2020
569e93a
Re-implemented `Uuid::fromString()` so it produces a `LazyUuidFromStr…
Ocramius Jun 30, 2020
0f68910
Optimized `Uuid::fromBytes()` de-serialization to use `LazyUuidFromSt…
Ocramius Jun 30, 2020
c018722
Add phpbench to CI run to ensure that we don't accidentally break ben…
Ocramius Jun 30, 2020
1ce3f55
Applied automated CS fixes according to project CS settings
Ocramius Jun 30, 2020
1f0cd71
Applied fixes and suppressions (sadly) to match psalm/phpstan code qu…
Ocramius Jun 30, 2020
910e3e4
Adjusted comment wording: s/string/strict (typo)
Ocramius Jul 1, 2020
2421b79
Added benchmark for UUID generation logic
Ocramius Jul 3, 2020
b805572
Ensure that `Uuid::uuidX()` generators produce instances equivalent t…
Ocramius Jul 3, 2020
a621ca9
`Uuid::uuid3()` uses impure `Uuid::getFactory()` API - suppressing it…
Ocramius Jul 9, 2020
6339cd9
Added UUID serialization benchmark
Ocramius Jul 9, 2020
fa14d04
Added benchmark about extracting UUID field details
Ocramius Jul 9, 2020
0c2b407
Minor performance optimization: `LazyUuidFromString#unwrap()` now use…
Ocramius Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
.readthedocs.yml export-ignore
.travis.yml export-ignore
docs/ export-ignore
phpbench.json export-ignore
phpcs.xml.dist export-ignore
phpunit.xml.dist export-ignore
resources/ export-ignore
Expand Down
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ script:
- ./resources/scripts/cmd-proxy.sh composer phpcs
- ./resources/scripts/cmd-proxy.sh composer phpstan
- ./resources/scripts/cmd-proxy.sh composer psalm
- ./resources/scripts/cmd-proxy.sh composer phpbench
- travis_wait 30 ./resources/scripts/cmd-proxy.sh ./vendor/bin/phpunit --verbose --coverage-clover build/logs/clover.xml

after_success:
Expand Down
4 changes: 4 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"php-mock/php-mock-mockery": "^1.3",
"php-mock/php-mock-phpunit": "^2.5",
"php-parallel-lint/php-parallel-lint": "^1.1",
"phpbench/phpbench": "^0.17.1",
"phpstan/extension-installer": "^1.0",
"phpstan/phpstan": "^0.12",
"phpstan/phpstan-mockery": "^0.12",
Expand Down Expand Up @@ -66,12 +67,14 @@
},
"autoload-dev": {
"psr-4": {
"Ramsey\\Uuid\\Benchmark\\": "tests/benchmark/",
"Ramsey\\Uuid\\StaticAnalysis\\": "tests/static-analysis/",
"Ramsey\\Uuid\\Test\\": "tests/"
}
},
"scripts": {
"lint": "parallel-lint src tests",
"phpbench": "phpbench run",
"phpcbf": "phpcbf -vpw --cache=build/cache/phpcs.cache",
"phpcs": "phpcs --cache=build/cache/phpcs.cache",
"phpstan": [
Expand All @@ -83,6 +86,7 @@
"phpunit-coverage": "phpunit --verbose --colors=always --coverage-html build/coverage",
"test": [
"@lint",
"@phpbench",
"@phpcs",
"@phpstan",
"@psalm",
Expand Down
10 changes: 10 additions & 0 deletions phpbench.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"bootstrap": "vendor/autoload.php",
"path": "tests/benchmark",
"retry_threshold": 5,
"reports": {
"report": {
"extends": "aggregate"
}
}
}
Loading