Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore #46

Closed
wants to merge 1 commit into from
Closed

Update .gitignore #46

wants to merge 1 commit into from

Conversation

GrahamCampbell
Copy link
Contributor

This stuff belongs in your system .gitignore file.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 492268c on GrahamCampbell:patch-1 into 7bf3ac0 on ramsey:master.

@GrahamCampbell
Copy link
Contributor Author

Ping @ramsey.

@ramsey
Copy link
Owner

ramsey commented Jan 22, 2015

@GrahamCampbell Do these hurt anything by remaining in the project .gitignore?

@GrahamCampbell
Copy link
Contributor Author

Yes and no. While not breaking anything here, they still encourage people to do this bad practice in their own projects.

@ramsey
Copy link
Owner

ramsey commented Jan 22, 2015

I don't understand why it's a bad practice. Can you elaborate?

@GrahamCampbell
Copy link
Contributor Author

@ramsey
Copy link
Owner

ramsey commented Jan 22, 2015

Thanks for the link, but that post seems to imply that, when working in teams, having these ignores in the project .gitignore file is still helpful:

When I create a new repository on which people may actually contribute, I’ll still create a proper ignore file, however. Otherwise I’d convey the message that I consider contributors as slaves who only deserve the boring work of creating ignore files. Since I’m pure of heart, that’s not how I roll.

Since multiple people work on this project, I think it's helpful to keep a robust .gitignore file for the project, since I can't assure that all developers will put the files in their global ignore file. Plus, I end up cloning this repo to multiple places, so I personally have to keep my global ignore files up-to-date on multiple systems. IMO, it's better for the project to keep track of the files it doesn't want to be committed.

@GrahamCampbell
Copy link
Contributor Author

@ramsey I don't agree. If people see files being staged by git that they don't expect to see, they'll probably check the docs and realize they're meant to be using a global ignore file.

@ramsey
Copy link
Owner

ramsey commented Feb 3, 2015

@GrahamCampbell I don't see the harm in leaving these values in .gitignore, so I'm going to leave them in place. I appreciate your interest in this library, and I hope you'll continue to use and support it through future pull requests. Thanks!

@ramsey ramsey closed this Feb 3, 2015
@GrahamCampbell GrahamCampbell deleted the patch-1 branch February 3, 2015 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants