fix: Amends psalm assertion syntax on Uuid::isValid() to prevent incorrect type inference
#486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correct type inference
ramsey
approved these changes
Jan 10, 2023
|
Just realised that I should be able to remove the PHPStan suppression shipped in the original PR - I'll rebase and try it… |
gsteel
force-pushed
the
amend-psalm-assertion-for-is-valid
branch
2 times, most recently
from
75c862c
to
85828da
Compare
|
The previous error suppression will have to stay for now :( |
|
I'm not sure why the workflow didn't run when you did the force push. Normally, that should have triggered a build. |
|
I've pushed an additional test case to trigger CI. GHA was being weird for me on other repos earlier! |
|
Thank you for contributing! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reason for this change is described in #478
Closes #478