Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): allow brick/math v0.11 #488

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jan 16, 2023

Description

Motivation and context

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@simPod simPod requested a review from ramsey as a code owner January 16, 2023 08:54
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #488 (df5cb24) into 4.x (433b201) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                4.x     #488   +/-   ##
=========================================
  Coverage     95.57%   95.57%           
  Complexity      584      584           
=========================================
  Files            70       70           
  Lines          1561     1561           
=========================================
  Hits           1492     1492           
  Misses           69       69           

@simPod
Copy link
Contributor Author

simPod commented Jan 25, 2023

@ramsey is there any chance to have this 🚢ed soon?

@ramsey
Copy link
Owner

ramsey commented Jan 25, 2023

Be patient, please. I've got a lot on my plate, and this PR is only a week old. 🙂

@simPod
Copy link
Contributor Author

simPod commented Jan 25, 2023

Aight, thanks for response!

@ramsey
Copy link
Owner

ramsey commented Jan 28, 2023

Thank you for contributing! 🎉

@ramsey ramsey merged commit 25c4faa into ramsey:4.x Jan 28, 2023
@simPod simPod deleted the allow-math-11 branch January 28, 2023 17:28
@simPod
Copy link
Contributor Author

simPod commented Feb 15, 2023

@ramsey can be have a release? It's blocking brick/math v0.11.0 adoption. Thanks

@Jimbolino
Copy link

now i know why all my laravel projects are installing 4.x-dev, even with "prefer-stable": true
(and "minimum-stability": "dev")

@hamrak
Copy link

hamrak commented Mar 31, 2023

Hi @ramsey , when is the release of this change planned?

@ramsey ramsey linked an issue Apr 15, 2023 that may be closed by this pull request
@ramsey
Copy link
Owner

ramsey commented Apr 15, 2023

This is released in version 4.7.4. Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Bump brick/math from ^0.10 to ^0.11
4 participants