Modify Char1 default to ora.S (string) from ora.B (bool).

rana · Apr 8, 2016 · 9b329a8 · 9b329a8
1 parent 6874186
commit 9b329a8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
   * Add numberBigInt and numberBigFloat colum types.
     This allows tweaking the used column types for NUMBER columns with unknown scale/precision.
   * OCINum instead of OraNum - space saving and less C calls (implemented pure Go read/write of Oracle OCINumber, in num directory).
+  * Modify default for CHAR(1) columns: use ora.S (string), NOT ora.B (bool).
 
 ## v3.3 ##
   * Introduce new `Num` and `OraNum` data types and `N` Go Column Type to represent Oracle numbers fully, by exchanging them with Go as strings.

diff --git a/README.md b/README.md
@@ -689,7 +689,7 @@ sc.StmtCfg.Rset.SetDate(ora.OraT)
 sc.StmtCfg.Rset.SetTimestamp(ora.OraT)
 sc.StmtCfg.Rset.SetTimestampTz(ora.OraT)
 sc.StmtCfg.Rset.SetTimestampLtz(ora.OraT)
-sc.StmtCfg.Rset.SetChar1(ora.OraB)
+sc.StmtCfg.Rset.SetChar1(ora.OraS)
 sc.StmtCfg.Rset.SetVarchar(ora.OraS)
 sc.StmtCfg.Rset.SetLong(ora.OraS)
 sc.StmtCfg.Rset.SetClob(ora.OraS)
@@ -707,6 +707,8 @@ Another scenario may be to configure the runes mapped to `bool` values:
 // update StmtCfg to change the FalseRune and TrueRune inserted into the database
 // given: CREATE TABLE T1 (C1 CHAR(1 BYTE))
 
+stmt.Cfg().Char1(ora.OraB)
+
 // insert 'false' record
 var falseValue bool = false
 stmt, err = ses.Prep("INSERT INTO T1 (C1) VALUES (:C1)")

diff --git a/doc.go b/doc.go
@@ -614,7 +614,7 @@ nullable Go types by default:
 	sc.StmtCfg.Rset.SetTimestamp(ora.OraT)
 	sc.StmtCfg.Rset.SetTimestampTz(ora.OraT)
 	sc.StmtCfg.Rset.SetTimestampLtz(ora.OraT)
-	sc.StmtCfg.Rset.SetChar1(ora.OraB)
+	sc.StmtCfg.Rset.SetChar1(ora.OraS)
 	sc.StmtCfg.Rset.SetVarchar(ora.OraS)
 	sc.StmtCfg.Rset.SetLong(ora.OraS)
 	sc.StmtCfg.Rset.SetClob(ora.OraS)
@@ -630,6 +630,8 @@ Another scenario may be to configure the runes mapped to bool values:
 	// update StmtCfg to change the FalseRune and TrueRune inserted into the database
 	// given: CREATE TABLE T1 (C1 CHAR(1 BYTE))
 
+	stmt.Cfg().Char1(ora.OraB)
+
 	// insert 'false' record
 	var falseValue bool = false
 	stmt, err = ses.Prep("INSERT INTO T1 (C1) VALUES (:C1)")

diff --git a/rsetCfg.go b/rsetCfg.go
@@ -47,7 +47,7 @@ func NewRsetCfg() RsetCfg {
 	c.timestamp = T
 	c.timestampTz = T
 	c.timestampLtz = T
-	c.char1 = B
+	c.char1 = S
 	c.char = S
 	c.varchar = S
 	c.long = S