getCategories function as exposed API

ranaalisaeed · May 30, 2021 · ee3d41f · ee3d41f
1 parent 4df155c
commit ee3d41f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 11 deletions.
diff --git a/src/charts/stackbar.test.ts b/src/charts/stackbar.test.ts
@@ -403,7 +403,7 @@ describe('Stackbar Chart', () => {
 		})
 
 		test('should provide maxValue getter and setter', () => {
-			const sample_categories = stackbarChart.categories()
+			const sample_categories = stackbarChart.getCategories(sample_data)
 			const data_maxVal = max(
 				sample_data.map(d => max(
 					[sum(sample_categories.map(k => d[k]))]	

diff --git a/src/charts/stackbar.ts b/src/charts/stackbar.ts
@@ -107,16 +107,16 @@ export default function stackbar(): any {
 	}
 
 
-	function getCategories(data: StackbarDatum[]): string[] {
-		return Array.from(new Set(data
-			.map(d => Object.keys(d))
-			.reduce((acc, val) => acc.concat(val), []) // alternative .flat()
-		)).slice(1)
-	}
+	// function getCategories(data: StackbarDatum[]): string[] {
+	// 	return Array.from(new Set(data
+	// 		.map(d => Object.keys(d))
+	// 		.reduce((acc, val) => acc.concat(val), []) // alternative .flat()
+	// 	)).slice(1)
+	// }
 
 
 	function getMaxValue(data: StackbarDatum[]): number {
-		let categories = getCategories(data)
+		let categories = _.getCategories(data)
 
 		const transformedData: number[] = data.map(d => {
 			return max([ sum( 
@@ -131,7 +131,7 @@ export default function stackbar(): any {
 	 * @param data StackbarDatum[]
 	 */
 	function buildScales(data: StackbarDatum[]): void {
-		let categories = getCategories(data)
+		let categories = _.getCategories(data)
 		let computedMaxValue = getMaxValue(data)
 
 		xScMkr = scaleBand()
@@ -196,7 +196,7 @@ export default function stackbar(): any {
 	 * @param data 
 	 */
 	function buildLayout(data: StackbarDatum[]): void {
-		let categories = getCategories(data)
+		let categories = _.getCategories(data)
 
 		let stackMkr = stack<StackbarDatum[]>()
 			.keys(categories)
@@ -345,7 +345,7 @@ export default function stackbar(): any {
 		let legendGroup: any = svg.select('.legend-group')
 
 		let existingElems = legendGroup.selectAll('.key-group')
-			.data(getCategories(data), (d: any) => d)
+			.data(_.getCategories(data), (d: any) => d)
 
 		let appendedElems = existingElems
 			.enter().append('g')
@@ -404,6 +404,13 @@ export default function stackbar(): any {
     return this
   }
 
+	_.getCategories = function(data: StackbarDatum[]): string[] {
+		return Array.from(new Set(data
+			.map(d => Object.keys(d))
+			.reduce((acc, val) => acc.concat(val), []) // alternative .flat()
+		)).slice(1)
+	}
+
 
 	return _
 }