Add argument to control duplicates in append #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the remove_duplicates argument to the collection.append() function to control how duplicates within the old and the new appended data are handled. Also added some documentation. It should be discussed if the remove_duplicates="all" option is useful or not. It should also be discussed if the default value remove_duplicates=None is the correct one. To be backwards compatible it needs to be set to remove_duplicates='values'. This only works for pd.Dataframes with single level index yet.
Delete comments from code since their are already in the function description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
remove_duplicatesargument tocollection.append()to control how duplicates within the old and the new appended data are handled.Also added some documentation.
It should be discussed if the
remove_duplicates="all"option is useful or not.It should also be discussed if the default value
remove_duplicates=Noneis the correct one.To be backwards compatible it needs to be set to
remove_duplicates='values'.This only works for pd.Dataframes with single level index yet.