Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional state options for controlling names of subnet resources #10

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Add optional state options for controlling names of subnet resources #10

merged 2 commits into from
Feb 13, 2020

Conversation

mgianatagh
Copy link
Contributor

Added optional state options for the following network components. This allows the caller of CreateVCNAndNetworkResources to customize the names associated with the service and node pool subnet for the VCN.

  • name for node pool subnet (default "nodedns")
  • name for security list of node pool subnet (default "Node Security List")
  • name for DNS domain of node pool subnet (default "nodedns")
  • name for security list of service subnet (default "Service Security List")
  • name for DNS domain of service subnet (default "svcdns")

Updated code to use these new state values. These new options default to the hard coded values that were previously being used.

Copy link
Collaborator

@jlamillan jlamillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jlamillan jlamillan merged commit 552968a into rancher-plugins:master Feb 13, 2020
@mgianatagh mgianatagh deleted the mgianatagh/new-state-options branch February 18, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants