Update deps #42
Merged
Update deps #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekarlso
force-pushed
the
update-deps
branch
2 times, most recently
from
01decd0
to
4e39f5f
Compare
|
Should we also upgrade versions of some components we use, like this one? The newest Version is v0.2.1 |
belgaied2
requested changes
Jun 17, 2024
There was a problem hiding this comment.
This PR seems to break a build because of controller-gen:v0.15 not supporting Golang 1.22.
This seems related to this known issue : golang/go#65637
Could you please bump controller-gen version and make sure that a make docker-build-all works correctly ?
Thank you
Signed-off-by: Mohamed Belgaied Hassine <belgaied2@hotmail.com>
belgaied2
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: