Add ADR explaining removal of kubebuilder defaults #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
added
the
kind/documentation
alexander-demicev
force-pushed
the
v1beta1adr
branch
from
3fd7b63
to
89228c4
Compare
Danil-Grigorev
previously approved these changes
May 21, 2024
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
v1beta1adr
branch
from
89228c4
to
32a9943
Compare
Danil-Grigorev
approved these changes
May 21, 2024
There was a problem hiding this comment.
This is just a question and not a blocker for merging the PR. Can this deprecation of default values cause an issue for users that have been using older versions of the provider? Let's say that a user provisions clusters via a GitOps tool (like Fleet) and they are missing some of the fields that no longer have a default value. Now they update CAPRKE2 to the new version that requires to set fields manually. Is it possible that this breaks their downstream cluster/s?
|
@salasberryfin Defaults are only evaluated on the first apply, then the applied data is stored in etcd, so all existing manifests should already have user defined values for these fields. |
|
Thanks @Danil-Grigorev. |
salasberryfin
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: