Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cmd/hypper/install.go.runInstall() functionality to pkg/, deduplicating it #127

Open
viccuad opened this issue Apr 14, 2021 · 0 comments
Open

Move cmd/hypper/install.go.runInstall() functionality to pkg/, deduplicating it #127

viccuad opened this issue Apr 14, 2021 · 0 comments
Labels
upstream interest in moving this upstream
Projects
Shit It

Comments

@viccuad
Copy link
Member

viccuad commented Apr 14, 2021

With #120, we introduced duplicated code between cmd/hypper/install.go.runInstall() and pkg/action.install.go.InstallSharedDep(). This happened because InstallSharedDep() needs to locate and pull the charts corresponding with the names and repos of the listed shared-deps.

In Helm, that functionality to locate, load chart from chart path, check chart for deprecation, build values, and check client version, has been part of cmd/. By implementing this card, we accept and move that to the pkg lib.
@viccuad viccuad added the upstream interest in moving this upstream label Apr 14, 2021
viccuad added a commit that referenced this issue Apr 14, 2021
@viccuad
chore: Drop TODO from runInstall()
47fef13 
Opened #127 for it.

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
@viccuad viccuad mentioned this issue Apr 14, 2021
Merged
@mattfarina mattfarina added this to To do in Shit It May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream interest in moving this upstream
Projects
Shit It
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@viccuad