-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search command #113
Add search command #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! having the search functionality in the libs sounds awesome :)
I have only done a fast review so far. Could we first double-check on the exported functions and methods that will be in the lib API? For example, maybe we don't need to expose WriteJSON() and WriteYAML(). Also, could we add comments to the exported ones? (it would help me with the review).
Unfortunately due to the convoluted way in which those functions are called they need to be exposed because
Will do! |
cd30b3b
to
7f07a7c
Compare
3cfacc5
to
2c9e381
Compare
user docs added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, as as we talked on the chat, is gonna get rebased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooohoo! nice, and with the cmd/helm/search
things in our own pkg/search
!
Approving, feel free the consider my reviews as passed if/when typos get pushed!
Adds the helm repo search command to hypper as just hypper search Under helm you can search on the repos or on their own hub. This patch only implements the repo search as seems the most useful and bringing the hub requires a lot of code. There is still room to bring the hub search into hypper if deemed necessary This patch also extracts the search code into a new pkg as under helm the search code is mostly crammed under cmd which means you cannot use it anywhere, meanwhile this code can be reused by third party clients to implement their own search frontend or automate it. Signed-off-by: Itxaka <igarcia@suse.com>
rebasing for the conflicts... |
was already approved by victor, I had to rebase due to merge conflicts on the root.go file (because lint added a command there and we are also adding a command) So merging :) |
Adds the helm repo search command to hypper as just hypper search
Under helm you can search on the repos or on their own hub. This
patch only implements the repo search as seems the most useful
and bringing the hub requires a lot of code
This patch also extracts the search code into a new pkg as under
helm the search code is mostly crammed under cmd which means you cannot
use it anywhere, meanwhile this code can be reused by third party
clients to implement their own search frontend or automate it.
Fixes: #78
Signed-off-by: Itxaka igarcia@suse.com