Keep only datasource providers #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cassany <david@localhost.localdomain>
Signed-off-by: David Cassany <david@localhost.localdomain>
Signed-off-by: Michael Schnerring <3743342+schnerring@users.noreply.github.com> (cherry picked from commit 488e416)
Signed-off-by: Michael Schnerring <3743342+schnerring@users.noreply.github.com> (cherry picked from commit f9ec8c2)
… to Azure-OVF provider Signed-off-by: Michael Schnerring <3743342+schnerring@users.noreply.github.com> (cherry picked from commit b765356)
Signed-off-by: Michael Schnerring <3743342+schnerring@users.noreply.github.com> (cherry picked from commit 9fd9697)
A backport of linuxkit#3614 (cherry picked from commit e06a1bd)
This commit ensures block device files are closed after opening then, this way utilities like parted will not complain if used within the same process in a later stage. Signed-off-by: David Cassany <dcassany@suse.com> (cherry picked from commit d63c438)
This commit attempts to mount eligible devices as iso9660 or as fat32. In addition it also removes some obsolete code related to an unused metadata field and properly tracks errors as error messages. Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
|
draft as the code is still untested |
|
Ship it ! 😆 |
Yes... what we use is just a forgotten little piece within this linuxkit beast... that's why I wanted to clean it up. I also noticed we gained vmware guestinfo support by rebasing on top of master again, would be nice to validate if it works or not. I guess it does since it was introduced recently. As soon I validate the cdrom datasource works as expected in yip I'll merge it, tag a new release and make a PR to yip to point to the new project and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to re structure the fork to only keep a refactored version of the
pkg/metadatacode as a single standalone golang library.