Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared and bridged networking are broken in 1.11.0 #6051

Closed
jandubois opened this issue Nov 25, 2023 · 0 comments · Fixed by lima-vm/lima#2033 or #6097
Closed

shared and bridged networking are broken in 1.11.0 #6051

jandubois opened this issue Nov 25, 2023 · 0 comments · Fixed by lima-vm/lima#2033 or #6097
Assignees
Labels
area/networking kind/bug Something isn't working platform/macos regression Functionality was working in a previous release and is now broken release-note
Milestone

Comments

@jandubois
Copy link
Member

jandubois commented Nov 25, 2023

Summary

In Rancher Desktop 1.11.0 the vde_vmnet and socket_vmnet options no longer work correctly.

The rd0 and rd1 interfaces exists, but have no corresponding default routes in the routing table. E.g. traefik ingress is not accessible over the bridged or shared interfaces.

The root cause is bumping Lima from 0.16.0 to 0.18.0. The error was introduced/exposed in lima-vm/lima#1898, which is restarting the network service at the end of the cloud-init boot sequence.

First boot

  • On first boot the VM starts without admin privileges and rd0/rd1 are not configured
  • lima-init creates /etc/network/interfaces
  • networking services starts
  • /etc is moved to /mnt/data/etc and mounted on top of the /etc location
  • networking services are restarted

Add bridged and shared networking

  • user enables admin mode, which causes a VM restart with the rd0/rd1 interfaces defined
  • lima-init creates /etc/network/interfaces with the updated setting
  • networking services start, including rd0/rd1
  • /mnt/data/etc is mounted on top of /etc
  • networking services are restarted, without rd0/rd1

Why it is broken

This last restart happens with the /etc/networking/interfaces file from the first-boot, and not the updated one from the current boot (which is hidden behind the bind-mount). Therefore it removes the rd0/rd1 interfaces again from the routing table.

Acceptance criteria

This issue should only be closed once the issue is fixed in Lima, we have bumped to the fixed Lima version, and have created a BATS test for it.

It should not be closed when the workaround from the 1.11.1 release is merged back into main.

@jandubois jandubois added kind/bug Something isn't working platform/macos area/networking triage/patch-candidate regression Functionality was working in a previous release and is now broken labels Nov 25, 2023
@jandubois jandubois added this to the 1.12 milestone Nov 25, 2023
@jandubois jandubois self-assigned this Nov 25, 2023
jandubois added a commit to jandubois/rancher-desktop that referenced this issue Nov 26, 2023
This is a workaround for rancher-sandbox#6051

It makes sure the boot-time /etc/network/interfaces file is copied
to the persisted location and then restarts the networking service
yet one more time.

This workaround should be removed when the issue is fixed upstream.

Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois added a commit to jandubois/rancher-desktop that referenced this issue Nov 26, 2023
This is a workaround for rancher-sandbox#6051

It makes sure the boot-time /etc/network/interfaces file is copied
to the persisted location and then restarts the networking service
yet one more time.

This workaround should be removed when the issue is fixed upstream.

Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking kind/bug Something isn't working platform/macos regression Functionality was working in a previous release and is now broken release-note
Projects
None yet
2 participants