Fixes the iptables option for older k8s #4774
Conversation
Nino-K
force-pushed
the
fix-enable-kubernetes
branch
from
58f7eb0
to
1768c21
Compare
- The previous logic to enable k8s and iptables didn't seem to be correct. The new changes relies on the actual config to determine enabling k8s. Signed-off-by: Nino Kodabande <nkodabande@suse.com>
Nino-K
force-pushed
the
fix-enable-kubernetes
branch
from
1768c21
to
5bf55ea
Compare
Signed-off-by: Nino Kodabande <nkodabande@suse.com>
There was a problem hiding this comment.
It looks like we still need -iptables when using nerdctl.
Tested with:
- container engine: containerd
- Kubernetes version: v1.26.5
- Old networking
Created a Kubernetes container:
kubectl run nginx --image nginx:stable --port 80 --exposekubectl edit svc nginxand change it to useNodePortcurl, that worked.
Created a containerd container:
nerdctl run -d --restart=always --publish 8111:80 nginx:stablecurldid not work.
I believe we still need to turn on iptables if we're using the containerd back end. I think I made a table in some random comment…
I'm probably thinking of #2593 (comment) or something like that.
There was a problem hiding this comment.
Looking at it more, I believe the fact that containerd is busted is a separate issue, and this PR is fine as it is.
However, we may need to fix up the table at https://github.com/rancher-sandbox/rancher-desktop-agent/blob/4616f600c9a58785ef52933b5e975086ccb258a8/cmd/rancher-desktop-guestagent/main.go#L60-L74 once we figure everything out to better describe the correct flags.
Fixes: #4730
Fixes: #4682