Fixes: #4560 ignore WSL Integration Error #5642
Conversation
Signed-off-by: dmerrill <douglas.merrill@suse.com>
Signed-off-by: dmerrill <douglas.merrill@suse.com>
| return this.syncDistroSocketProxy(distro.name, !reason); | ||
| } catch (error) { | ||
| console.error(`syncSocketProxy ${ distro.name } Error: ${ error }`); |
There was a problem hiding this comment.
syncDistroSocketProxy is async, but this anonymous function is not; so the catch will not catch rejected promises, but the outer await Promise.all will (and still throw an exception).
Given the other changes, do you want to wrap syncDistroSocketProxy in try/catch instead?
There was a problem hiding this comment.
Nice catch! Change has been checked in.
Signed-off-by: dmerrill <douglas.merrill@suse.com>
| * distribution is started or stopped, as desired. | ||
| * @param distro The distribution to manage. | ||
| * @param shouldRun Whether the docker socket proxy should be running. | ||
| * @note this function can not throw because the callers are expecting promises. |
There was a problem hiding this comment.
| * @note this function can not throw because the callers are expecting promises. | |
| * @note this function must not throw. |
The fact that the callers want promises isn't quite the issue; the fact that throwing breaks startup is…
(Using "must not" to avoid ambiguity, see also RFC 2119 though we're not following that here.)
There was a problem hiding this comment.
Makes sense. Change made.
| * syncDistroDockerPlugin ensures that a plugin is accessible in the given distro. | ||
| * @param distro The distribution to manage. | ||
| * @param pluginName The plugin to validate. | ||
| * @note this function can not throw because the callers are expecting promises. |
There was a problem hiding this comment.
| * @note this function can not throw because the callers are expecting promises. | |
| * @note this function must not throw. |
See above for explanation.
There was a problem hiding this comment.
Makes sense. Change made.
Signed-off-by: dmerrill <douglas.merrill@suse.com>
Please fix it anyways in your PR, to get the tests to pass! As Larry Wall once wrote:
|
Signed-off-by: dmerrill <douglas.merrill@suse.com>
Display WSL Integration status in GUI, but ignore any failures at startup.