Exclude default serviceaccount on backup #195
Conversation
| for _, resObj := range resourceObjectsList.Items { | ||
| metadata := resObj.Object["metadata"].(map[string]interface{}) | ||
| name := metadata["name"].(string) | ||
| nameMatched, err := regexp.MatchString(filter.ExcludeResourceNameRegexp, name) |
There was a problem hiding this comment.
If I'm understanding this correctly, this line should return true if the string in the variable name starts or ends with default, but I tried this in the go playground using the pattern ^default$ and got false instead. I do get that behavior if I use the pattern ^default|default$, but I see we are using the ^<string>$ pattern to match other things already so am I missing something? https://go.dev/play/p/7EtHr0IZKfR
There was a problem hiding this comment.
The exclude is for service accounts called default, the playground shows comparing token names with the regex. We are excluding the default service accounts created in each namespace and they are named default. Let me know if I need to add some clarification in the issue or code.
There was a problem hiding this comment.
Okay, makes sense now. I think the comment you linked to is good, this is just my first time reviewing the backup-restore-operator.
#165
Root cause is described in #165 (comment)