Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment names the created claim like the given volume name #274

Merged
merged 1 commit into from Nov 21, 2022

Conversation

RudiMT
Copy link
Contributor

@RudiMT RudiMT commented Oct 12, 2022

#94

Squashed #267

@RudiMT RudiMT marked this pull request as draft October 12, 2022 11:51
@RudiMT RudiMT marked this pull request as ready for review October 12, 2022 12:03
superseb
superseb previously approved these changes Oct 12, 2022
@superseb
Copy link
Contributor

Oh, the base branch needs to be changed @RudiMT as only release/vX.X branches are used. To be included in the latest, it needs to be release/v3.0.

@RudiMT RudiMT changed the base branch from master to release/v3.0 October 12, 2022 15:19
@RudiMT RudiMT dismissed superseb’s stale review October 12, 2022 15:19

The base branch was changed.

@RudiMT RudiMT requested review from superseb and removed request for eliyamlevy October 12, 2022 15:20
@eliyamlevy
Copy link
Contributor

Hi @RudiMT thanks for the PR! We'll be waiting a bit to merge this for the next release. Appreciate the contribution.

@eliyamlevy eliyamlevy merged commit d82ad6b into rancher:release/v3.0 Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants