Prevent multiple restores #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrajashree
force-pushed
the
leaserestore
branch
4 times, most recently
from
3ca1f3f
to
6e009f6
Compare
mrajashree
force-pushed
the
leaserestore
branch
7 times, most recently
from
566438a
to
50f79c8
Compare
dramich
reviewed
Sep 30, 2020
dramich
reviewed
Sep 30, 2020
mrajashree
force-pushed
the
leaserestore
branch
from
50f79c8
to
19663d1
Compare
mrajashree
force-pushed
the
leaserestore
branch
from
19663d1
to
03f4185
Compare
dramich
reviewed
Sep 30, 2020
Comment on lines
+113
to
+115
| lease, err := leaseClient.Get(ctx, leaseName, k8sv1.GetOptions{}) | ||
| if err == nil && lease != nil { | ||
| leaseClient.Delete(ctx, leaseName, k8sv1.DeleteOptions{}) |
There was a problem hiding this comment.
I think this could cause issues in the future if we have more than one running but should be fine for now.
There was a problem hiding this comment.
made an issue for 2.5.x to track it
dramich
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9