Update release/4.0 from recent release/3.0 changes #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandreLamarre
previously approved these changes
Feb 23, 2024
Original was too greedy when dealing with both ResourceNameRegexp and ExcludeResourceNameRegexp Fixed issue with ResourceName Filtering
This change adds in a number of unit tests that cover supported filter scenarios for name based filters. Additionally we renamed a few methods to better make their name match their use/purpose. Finally this change does fix an issue in the deduplication logic.
And this technique lets us reuse input files.
* Further refactoring: simplify and test kind and namespace matching. * Added tests to verify that invalid regular expressions are caught as recoverable error messages (and runtime testing showed that they were reported and backups continued).
- Also: stop checking for a regexp == "." -- let the engine do it. Benchmarking shows the pattern-matching is a touch faster even with the function call
ericpromislow
force-pushed
the
release/v4.0
branch
from
6c9a070
to
3ae25a7
Compare
alexandreLamarre
approved these changes
Feb 26, 2024
| catalog.cattle.io/release-name: rancher-backup | ||
| catalog.cattle.io/scope: management | ||
| catalog.cattle.io/type: cluster-tool | ||
| catalog.cattle.io/ui-component: rancher-backup | ||
| catalog.cattle.io/upstream-version: 2.1.1 | ||
| catalog.cattle.io/upstream-version: 3.0.0 |
There was a problem hiding this comment.
should this match the base branch of release/v4.0.0 as 4.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these changes should be due to rebasing
release/v3.0ontorelease/v4.0