Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minio-go and wrangler libraries #429

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

mallardduck
Copy link
Member

@mallardduck mallardduck commented Mar 28, 2024

Also bump golang per requirements of other updates.

Tested on Cluster with:

Runtime Node Count Rancher Version BRO Chart
v1.26.11+k3s1 6 (3workers) v2.7.11 rancher-backup:102.0.3+up3.1.3

Test Steps

  • Took a backup (B1)
  • Swapped out backups image for my PR image,
  • Took a new backup (B2),
  • Changed local rancher cluster name,
  • Took another backup (B3)
  • Restored to backup taken before using new image (B1),
  • Verify changes restored as expected,
  • Restore backup taken after name change (B3) to go back to "newest",
  • Verify changes,
  • restore backup taken on new image before name change (B2)

Compatibility and Test Risks

Rancher deps (wrangler and lasso)

Per our readme, current BRO releases should only need to target Rancher 2.7.x and up.

the tag v3.x.x is cut from the release/v3.0 branch for Rancher v2.7.x line

Looking at rancher/wrangler it seems we are safe to (and should) bump Wrangler to match this minimum. Per Wrangler docs, 1.0.x was meant for 2.6.x and 1.1.x for 2.7.x. Similarly lasso looks to be pretty safe as all those changes are rather minor.

K8s.io deps

For all the k8s.io dependencies that updated we should be pretty good for compatibility. Since it's all client code tied to specific k8s server versions - the biggest risk is lacking feature support for k8s newer than the one we use. And potentially more concerning removal of features from the client that old k8s may still have.

@mallardduck
Copy link
Member Author

mallardduck commented Mar 29, 2024

🤦 Just realized I forgot to run go generate after the wrangler version changes which is why CI is failing. So I need to properly do that, rebuild the project, rebuild images and retest. Update: Things have been retested now.

@MKlimuszka
Copy link

Also bump golang per requirements of other updates
Copy link
Collaborator

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my tests passed

@ericpromislow ericpromislow merged commit f1df7d7 into rancher:release/v3.0 Apr 3, 2024
1 check passed
@MKlimuszka MKlimuszka added this to the v2.7-Patch1 milestone Apr 30, 2024
@MKlimuszka
Copy link

General regression testing done during chart sign off will suffice for testing.

@nickwsuse nickwsuse removed their assignment Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants