Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.9 ]Add istio 1.22.1 #4095

Merged

Conversation

diogoasouza
Copy link
Contributor

@diogoasouza diogoasouza commented Jun 14, 2024

@diogoasouza diogoasouza force-pushed the add-kubernetes-130-support-to-istio branch 5 times, most recently from d329cd5 to 98fe9b8 Compare June 20, 2024 18:34
@diogoasouza diogoasouza marked this pull request as ready for review June 20, 2024 18:46
@diogoasouza diogoasouza requested a review from a team as a code owner June 20, 2024 18:46
@rancher rancher deleted a comment from github-actions bot Jun 20, 2024
@rancher rancher deleted a comment from github-actions bot Jun 20, 2024
@rancher rancher deleted a comment from github-actions bot Jun 20, 2024
@rancher rancher deleted a comment from github-actions bot Jun 20, 2024
@rancher rancher deleted a comment from github-actions bot Jun 20, 2024
@diogoasouza diogoasouza force-pushed the add-kubernetes-130-support-to-istio branch from 98fe9b8 to 7df835f Compare June 20, 2024 18:48
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@rancher rancher deleted a comment from github-actions bot Jun 20, 2024
Copy link
Member

@rohitsakala rohitsakala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should we increase package version for jaeger like this one ?
  2. Should we increase version for kiali like this one ?

@diogoasouza
Copy link
Contributor Author

  1. Should we increase package version for jaeger like this one ?
  2. Should we increase version for kiali like this one ?

We can, but AFAIK this is not used anywhere since it's a subchart, I don't think we actually even need them

@rohitsakala
Copy link
Member

  1. Should we increase package version for jaeger like this one ?
  2. Should we increase version for kiali like this one ?

We can, but AFAIK this is not used anywhere since it's a subchart, I don't think we actually even need them

We should remove them if they are not used.

@diogoasouza diogoasouza force-pushed the add-kubernetes-130-support-to-istio branch from 7df835f to eaba506 Compare June 20, 2024 19:36
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@diogoasouza
Copy link
Contributor Author

Updated the PR @rohitsakala

@diogoasouza diogoasouza merged commit 18c43ea into rancher:dev-v2.9 Jun 20, 2024
6 checks passed
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants