Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] rancher-provisioning-capi 104.0.0+up0.3.0-rc.1 add #4107

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

chiukapoor
Copy link
Contributor

@chiukapoor chiukapoor commented Jun 20, 2024

Update

Related

@chiukapoor chiukapoor requested a review from a team as a code owner June 20, 2024 05:22
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@snasovich snasovich requested a review from a team June 20, 2024 16:50
Copy link
Contributor

@Oats87 Oats87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure of why we're updating a chart that is now in dev-v2.9 ... seems the upstream chart version should have been bumped when we updated the CAPI version.

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@chiukapoor chiukapoor changed the title [dev-v2.9] rancher-provisioning-capi 104.0.0+up0.2.0 update [dev-v2.9] rancher-provisioning-capi 104.0.0+up0.3.0-rc.1 update Jun 21, 2024
@chiukapoor chiukapoor changed the title [dev-v2.9] rancher-provisioning-capi 104.0.0+up0.3.0-rc.1 update [dev-v2.9] rancher-provisioning-capi 104.0.0+up0.3.0-rc.1 add Jun 21, 2024
Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@chiukapoor
Copy link
Contributor Author

I'm unsure of why we're updating a chart that is now in dev-v2.9 ... seems the upstream chart version should have been bumped when we updated the CAPI version.

Bumped the upstream chart 0.3.0-rc.1 and added rancher-provisioning-capi 104.0.0+up0.3.0-rc.1 chart

@chiukapoor chiukapoor requested a review from Oats87 June 21, 2024 15:24
Copy link
Contributor

@snasovich snasovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chiukapoor , thank you for updating the versioning.
However, we don't want to release both 104.0.0+up0.3.0-rc.1 and 104.0.0+up0.2.0 charts. 104.0.0+up0.3.0-rc.1 should basically replace 104.0.0+up0.2.0.

Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@chiukapoor
Copy link
Contributor Author

@chiukapoor , thank you for updating the versioning. However, we don't want to release both 104.0.0+up0.3.0-rc.1 and 104.0.0+up0.2.0 charts. 104.0.0+up0.3.0-rc.1 should basically replace 104.0.0+up0.2.0.

Removed chart 104.0.0+up0.2.0 in d03e9ab

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@vardhaman22 vardhaman22 merged commit 8d876d9 into rancher:dev-v2.9 Jun 25, 2024
6 checks passed
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request Jul 15, 2024
…r#4107)

Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
Co-authored-by: Vardhaman Surana <vardhaman.surana@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants