Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.9] Bump webhook to v0.5.0-rc9 #4133

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

pmatseykanets
Copy link
Contributor

Issue:

Problem

Solution

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@pmatseykanets pmatseykanets self-assigned this Jun 26, 2024
@pmatseykanets pmatseykanets requested a review from a team as a code owner June 26, 2024 20:14
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@pmatseykanets pmatseykanets marked this pull request as draft June 26, 2024 20:29
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@pmatseykanets pmatseykanets marked this pull request as ready for review June 27, 2024 00:42
Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmatseykanets pmatseykanets merged commit 2686ee1 into rancher:dev-v2.9 Jun 27, 2024
7 checks passed
@pmatseykanets pmatseykanets deleted the webhook-v0.5.0-rc9 branch June 27, 2024 02:40
@pmatseykanets pmatseykanets changed the title [v2.9] Bump webhook v0.5.0-rc9 [v2.9] Bump webhook to v0.5.0-rc9 Jun 27, 2024
krunalhinguu pushed a commit to krunalhinguu/charts that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants